Update logging.rst#516
Merged
Merged
Conversation
added 2 commits
February 10, 2015 17:15
The PEP referenced for configuring logging via - '319' should be '391'. Just a simple fix.
The name of a dictionary key `root` was not properly enclosed in quotes, which results in a syntax error when people copy this code. Thanks!
Contributor
There was a problem hiding this comment.
While you're here, could you also remove the space before the :?
Removed whitespace in violation of PEP 8 and aligned lines.
Contributor
Author
|
@sigmavirus24 I've gotten rid of that space. Should have caught it earlier. |
Contributor
|
Thanks @eikonomega ! |
Contributor
Author
|
Thank you for your awesomely quick response! On Tue, Feb 10, 2015 at 10:25 PM, Ian Cordasco notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of simple fixes on the logging page: