Code blocks#393
Conversation
Reads easier when viewing the source
|
Hey @Zearin thanks for this! There is going to be some work necessary before this is merged though. You made some unnecessary changes in certain places, but on the whole this is fantastic. Thank you! 🍰 |
There was a problem hiding this comment.
Might as well split these up. They are separate tools although they are very related. They should also both be capitalized, e.g., Pip.
There was a problem hiding this comment.
RE-fixed in 5f86330 (forgot the capitalization! :P)
|
Also, for each thing you fix, reply to each of my comments with "Fixed in ". If possible, keep the commits as small as possible. |
You’re welcome! :) Gonna start on your comments shortly… |
To any style-obsessed writers or editors reading this commit: The comma (or lack of one) after “e.g.” or “i.e.” has always bugged me. I finally looked it up! Here’s what I found: http://english.stackexchange.com/questions/16172/should-i-always-use-a-comma-after-e-g-or-i-e
|
Okay @sigmavirus24…fixed the last of your comments! Let me know if there is anything else I should fix. :) P.S.: (BTW, is your handle a Mega Man X reference? God that was an awesome game…) |
|
It is a reference to that. I think you're the first to get it. An extra slice of 🍰 for you. Thanks for all of this! |
Hey, @kennethreitz! Love your work, and this book. :)
I made some “janitorial” type edits here. They are almost entirely related to specifying the syntax for code-blocks.
I figured I’d start simple, because I’m not used to writing in ReST. That said…I honestly have no idea if I broke anything. (ReST is powerful, but I can never get the syntax straight from memory, so I usually prefer markdown).
If I did break something, just comment on the broken part(s) in the diff, and I’ll fix it up.
If this works out, I have some more edits in the works…