Skip to content

Cython description and code example added #370

Merged
kennethreitz merged 6 commits into
realpython:masterfrom
tommy3001:master
Mar 5, 2014
Merged

Cython description and code example added #370
kennethreitz merged 6 commits into
realpython:masterfrom
tommy3001:master

Conversation

@tommy3001
Copy link
Copy Markdown
Contributor

I think that is possibly a next stone for our church.

Comment thread docs/scenarios/speed.rst Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your indentation here is incorrect. The first line needs to be indented by 4 and the function body needs to be dedented by 4.

@tommy3001
Copy link
Copy Markdown
Contributor Author

You are right, i will do it. Thank you for the tip!

@tommy3001 tommy3001 closed this Feb 15, 2014
@sigmavirus24
Copy link
Copy Markdown
Contributor

@tommy3001 please do not open a new Pull Request. If you continue to make changes and push them to your fork, this Pull Request will update and we can continue the discussion in one place.

@sigmavirus24 sigmavirus24 reopened this Feb 15, 2014
@tommy3001
Copy link
Copy Markdown
Contributor Author

Fixed

Comment thread docs/scenarios/speed.rst Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same indentation fixes here as above please.

@sigmavirus24
Copy link
Copy Markdown
Contributor

@tommy3001 you're almost there. Thanks for this! It looks like it will be an awesome contribution! 🍰

@tommy3001
Copy link
Copy Markdown
Contributor Author

Ok, right.

Thank you for your patience.

I will commit machine competition in future. :)

@sigmavirus24
Copy link
Copy Markdown
Contributor

You missed one last block of indentation necessary. I haven't read the copy closely, so there may be future changes necessary but if they're minor I might just merge this and handle them myself.

@tommy3001
Copy link
Copy Markdown
Contributor Author

Big sorry, I made some copy/paste misstakes from my code/ide source.

I added an additional benchmark. ;-)

@sigmavirus24
Copy link
Copy Markdown
Contributor

No need to apologize. Noone is upset. =)

@reicheltd
Copy link
Copy Markdown

nice addition tommy

@sigmavirus24
Copy link
Copy Markdown
Contributor

You start most of your sentences with With Cython or really With .... I'm going to leave some feedback to help you reword them to avoid that pattern.

Comment thread docs/scenarios/speed.rst
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`Cython <http://cython.org/>`_ implements a superset of the Python language with which you are able to write C and C++ modules for Python. Cython also allows you to call functions from compiled C libraries. Using Cython allows you to take advantage of Python's strong typing of variables and operations. Here is an example of strong typing with Cython:

As a side note, I hope you realize that static typing is not strong typing. C is inherently weakly typed and Python strongly typed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this one too it seems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants