@Cronan i can't find any reference to this particular issue, i understand that writing unit test for this is hard, but please provide a reference comment or exception traceback at least.

@denfromufa The issue in #613 from System import Environment is caused by this bug - it occurs in Linux using .Net Core 2.0, when using the code from #612.

I'll add a test that exercises the import above, but it will only fail when #612 is merged into master (and if the above code isn't added)

Codecov Report

Merging #622 into master will increase coverage by 1.91%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #622      +/-   ##
========================================
+ Coverage   75.09%    77%   +1.91%     
========================================
  Files          60     64       +4     
  Lines        5480   5614     +134     
  Branches      864    890      +26     
========================================
+ Hits         4115   4323     +208     
+ Misses       1064   1002      -62     
+ Partials      301    289      -12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8629e1e...1cfc844. Read the comment docs.

@denfromufa Added a test, merged from #621, and squashed.

@Cronan let's wait for CI to finish

@denfromufa Sorry (sadface)

I also have related PR #528

That exists since summer 2017.

@dmitriyse this PR addresses one stand-alone issue, I'm in favor of merging your PR, if it totally covers this case and if you cherry pick the unit test from this PR to your PR.

@dmitriyse @denfromufa It seems I spent a lot of time yesterday debugging and fixing an issue that has already been fixed, but was left unreviewed and unmerged. :-(

What is hard about this project right now is the large number of issues, combined with a large number of unreviewed and unmerged PRs, which make it increasingly difficult for new people to work on the project. Obviously #610 was meant to address this, but I think we also need to work through the PRs, and either merge, fix, or close them. Maybe we could take them one at a time, and focus in on them?

@Cronan with new rules in issue #610 we should be able to faster merge existing PRs at least between me and @dmitriyse. I have more time this year than in second half of 2017. Soon we may add more reviewers from active people with few accepted PRs.

@Cronan also checkout the featured branch:

https://github.com/pythonnet/pythonnet/tree/featured

Thanks @denfromufa

@denfromufa I'm going to close this, I'll add the test (with a few others) by itself as a separate PR to extend code coverage.
@dmitriyse I'm not sure #528 actually address the issue of importing System.Environment in dotnetcoreapp2.0 on Linux, but I may be wrong.