gh-149078: test_socket: verify runtime kernel support for UDPLite#149081
Open
mcepl wants to merge 1 commit intopython:mainfrom
Open
gh-149078: test_socket: verify runtime kernel support for UDPLite#149081mcepl wants to merge 1 commit intopython:mainfrom
mcepl wants to merge 1 commit intopython:mainfrom
Conversation
78a5359 to
5316c65
Compare
The test suite previously only checked for the existence of the socket.IPPROTO_UDPLITE constant. This caused test failures on systems where the constant is defined in headers (and thus present in the interpreter) but the protocol is not supported or enabled in the running kernel (e.g., restricted build environments). This change adds a _have_socket_udplite() helper that performs a runtime check by attempting to create a UDPLite socket, aligning its behavior with other optional protocols like RDS or AF_ALG.
5316c65 to
ec03728
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite previously only checked for the existence of the
socket.IPPROTO_UDPLITEconstant. This caused test failures on systems where the constant is defined in headers (and thus present in the interpreter) but the protocol is not supported or enabled in the running kernel (e.g., restricted build environments).This change adds a
_have_socket_udplite()helper that performs a runtime check by attempting to create aUDPLitesocket, aligning its behaviour with other optional protocols likeRDSorAF_ALG.Fixes: #149078