gh-144285: Improve AttributeError attribute suggestions#144299
Merged
pablogsal merged 21 commits intopython:mainfrom Feb 12, 2026
Merged
gh-144285: Improve AttributeError attribute suggestions#144299pablogsal merged 21 commits intopython:mainfrom
AttributeError attribute suggestions#144299pablogsal merged 21 commits intopython:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Benefit isn't as clear as for `AttributeError` -- let's not change it if not necessary
This is extremely unlikely Keeping parity with this case would just be unhelpful
johnslavik
commented
Feb 7, 2026
AttributeError attribute suggestions
Member
Author
|
I caught one inconsistency. Give me a sec |
pablogsal
approved these changes
Feb 12, 2026
Member
|
Great work @johnslavik 👌 |
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
johnslavik
added a commit
to johnslavik/cpython
that referenced
this pull request
Feb 21, 2026
pablogsal
pushed a commit
that referenced
this pull request
Feb 21, 2026
brijkapadia
pushed a commit
to brijkapadia/cpython
that referenced
this pull request
Feb 28, 2026
brijkapadia
pushed a commit
to brijkapadia/cpython
that referenced
this pull request
Feb 28, 2026
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing up tests and adding news soon and we're ready.
I think it's okay this would affect simple cases as well. Error messages ideally are detailed and actionable.