Skip to content

gh-114149: fix tuple subclass handling when using custom __new__ - #114160

Merged
ethanfurman merged 2 commits into
python:mainfrom
ethanfurman:enum-tuple
Jan 17, 2024
Merged

gh-114149: fix tuple subclass handling when using custom __new__#114160
ethanfurman merged 2 commits into
python:mainfrom
ethanfurman:enum-tuple

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Jan 17, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@ethanfurman ethanfurman added type-bug An unexpected behavior, bug, or error stdlib Standard Library Python modules in the Lib/ directory 3.11 only security fixes 3.12 only security fixes needs backport to 3.11 only security fixes 3.13 bugs and security fixes needs backport to 3.12 only security fixes labels Jan 17, 2024
@ethanfurman ethanfurman self-assigned this Jan 17, 2024
@ethanfurman ethanfurman changed the title fix tuple subclass handling when using custom __new__ gh-114149: fix tuple subclass handling when using custom __new__ Jan 17, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 17, 2024
Closed
@ethanfurman ethanfurman added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 17, 2024
@bedevere-bot

bedevere-bot commented Jan 17, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ethanfurman for commit 05e142b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 17, 2024
@ethanfurman
ethanfurman merged commit 33b47a2 into python:main Jan 17, 2024
@miss-islington-app

miss-islington-app Bot commented Jan 17, 2024

Copy link
Copy Markdown

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 17, 2024
@ethanfurman @miss-islington
pythongh-114149: [Enum] fix tuple subclass handling when using custom…
3048a26 
… __new__ (pythonGH-114160)

(cherry picked from commit 33b47a2)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@ethanfurman
ethanfurman deleted the enum-tuple branch January 17, 2024 17:47
@bedevere-app

bedevere-app Bot commented Jan 17, 2024

Copy link
Copy Markdown

GH-114196 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 17, 2024
@ethanfurman @miss-islington
pythongh-114149: [Enum] fix tuple subclass handling when using custom…
27ab774 
… __new__ (pythonGH-114160)

(cherry picked from commit 33b47a2)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Jan 17, 2024
@bedevere-app

bedevere-app Bot commented Jan 17, 2024

Copy link
Copy Markdown

GH-114197 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Jan 17, 2024
ethanfurman added a commit that referenced this pull request Jan 17, 2024
@miss-islington @ethanfurman
[3.12] gh-114149: [Enum] fix tuple subclass handling when using custo…
c1890e6 
…m __new__ (GH-114160) (GH-114196)

(cherry picked from commit 33b47a2)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@ethanfurman
ethanfurman restored the enum-tuple branch January 17, 2024 21:50
@ethanfurman ethanfurman removed type-bug An unexpected behavior, bug, or error stdlib Standard Library Python modules in the Lib/ directory labels Jan 17, 2024
@ethanfurman ethanfurman added tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes and removed 3.11 only security fixes labels Jan 17, 2024
@miss-islington-app

miss-islington-app Bot commented Jan 17, 2024

Copy link
Copy Markdown

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jan 17, 2024

Copy link
Copy Markdown

Sorry, @ethanfurman, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 33b47a2c2853066b549f242065f6c2e12e18b33b 3.12

@ethanfurman ethanfurman added type-bug An unexpected behavior, bug, or error stdlib Standard Library Python modules in the Lib/ directory and removed tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes labels Jan 17, 2024
@ethanfurman

ethanfurman commented Jan 17, 2024

Copy link
Copy Markdown
Member Author

This PR has been reverted.

ethanfurman added a commit that referenced this pull request Jan 18, 2024
@ethanfurman
gh-114149: [Enum] revert #114160 and add more tuple-subclass tests (G…
4c7e09d 
…H-114215)

This reverts commit 05e142b.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2024
@ethanfurman @miss-islington
pythongh-114149: [Enum] revert pythonGH-114160 and add more tuple-sub…
6eb359b 
…class tests (pythonGH-114215)

This reverts commit 05e142b.
(cherry picked from commit 4c7e09d)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman added a commit that referenced this pull request Jan 18, 2024
@miss-islington @ethanfurman
[3.12] gh-114149: [Enum] revert GH-114196 and add more tuple-subclass…
35e330b 
… tests (GH-114215) (GH-114218)

gh-114149: [Enum] revert GH-114160 and add more tuple-subclass tests (GH-114215)

This reverts commit 05e142b.
(cherry picked from commit 4c7e09d)

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@ethanfurman @kulikjak
pythongh-114149: [Enum] fix tuple subclass handling when using custom…
993a866 
… __new__ (pythonGH-114160)
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@ethanfurman @kulikjak
pythongh-114149: [Enum] revert python#114160 and add more tuple-subcl…
84fb0ac 
…ass tests (pythonGH-114215)

This reverts commit 05e142b.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@ethanfurman @aisk
pythongh-114149: [Enum] fix tuple subclass handling when using custom…
439f303 
… __new__ (pythonGH-114160)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@ethanfurman @aisk
pythongh-114149: [Enum] revert python#114160 and add more tuple-subcl…
501f447 
…ass tests (pythonGH-114215)

This reverts commit 05e142b.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ethanfurman @Glyphack
pythongh-114149: [Enum] fix tuple subclass handling when using custom…
c1b62a8 
… __new__ (pythonGH-114160)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ethanfurman @Glyphack
pythongh-114149: [Enum] revert python#114160 and add more tuple-subcl…
5d3cd00 
…ass tests (pythonGH-114215)

This reverts commit 05e142b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ethanfurman ethanfurman

Labels

3.12 only security fixes 3.13 bugs and security fixes stdlib Standard Library Python modules in the Lib/ directory type-bug An unexpected behavior, bug, or error

Projects

enum issues
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ethanfurman @bedevere-bot