GH-65056: Improve the IP address' is_global/is_private documentation - #113186
Merged
Conversation
…ation It wasn't clear what the semantics of is_global/is_private are and, when one gets to the bottom of it, it's not quite so simple (hence the exceptions listed). I opted to fully replace the docstrings with the content from the documentation to save myself some work.
commented
Dec 15, 2023
Contributor
Author
|
I think the news entry can be safely skipped here. Note that the documentation is accurate assuming that #113179 gets merged and the I'll adapt the documentation as needed. |
encukou
reviewed
Mar 13, 2024
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
commented
Mar 13, 2024
Contributor
Author
|
That's more than fair, all suggestions applied. |
commented
Apr 23, 2024
|
GH-118177 is a backport of this pull request to the 3.12 branch. |
This was referenced Apr 23, 2024
commented
May 30, 2024
Contributor
Author
|
For visibility: I created GH-119812 to handle the Shared Address Space ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It wasn't clear what the semantics of is_global/is_private are and, when one gets to the bottom of it, it's not quite so simple (hence the exceptions listed).
I opted to fully replace the docstrings with the content from the documentation to save myself some work.
📚 Documentation preview 📚: https://cpython-previews--113186.org.readthedocs.build/