-
-
Notifications
You must be signed in to change notification settings - Fork 37.4k
quic: StopSending callback #63657
Copy link
Copy link
Closed
Labels
quicIssues and PRs related to the QUIC transport implementation.Issues and PRs related to the QUIC transport implementation.
Description
Activity
Metadata
Metadata
Assignees
Labels
quicIssues and PRs related to the QUIC transport implementation.Issues and PRs related to the QUIC transport implementation.
The docs for
QuicStream'sonresetcallback says:1.) How can the receiver determine, if it is a RESET_STREAM frame or a STOP_SENDING frame. This is actually a big difference. So do we need a separate
onstopsending? Or is it possible to have a property to determine this?Or may be one sees it in the iterable?
2.) It does not look as if it is invoked for a STOP_SENDING frame, see:
node/src/quic/streams.cc
Line 1787 in 30a7e28
it is just interacting with the stream.
@jasnell I may discover, that this is actually not a problem if one iterates the stream, what I am not sure yet,