-
-
Notifications
You must be signed in to change notification settings - Fork 37.3k
Add validation for internal binding functions #58162
Copy link
Copy link
Closed as not planned
Labels
metaIssues and PRs related to the general management of the project.Issues and PRs related to the general management of the project.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
Description
Activity
Metadata
Metadata
Assignees
Labels
metaIssues and PRs related to the general management of the project.Issues and PRs related to the general management of the project.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
When a function is added to one of the internal bindings its types should be added to the internalBindings typings (so that the type can be picked up by IDEs and be reflected in the lib javascript files).
Currently (as far as I know) there is no type checking being applied to the js files, so it's pretty easy to forget to add the appropriate typings.
Ideally a process should be put in place to validate that all types defined in internal bindings are present in the typings directory (matching the idea described in the onboarding documentation that tooling should identify PR issues when possible)
original conversation