-
-
Notifications
You must be signed in to change notification settings - Fork 37.3k
Leftovers after test-child-process-exec-abortcontroller-promisified #58118
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
abortcontrollerIssues and PRs related to the AbortController and AbortSignal APIs.Issues and PRs related to the AbortController and AbortSignal APIs.child_processIssues and PRs related to the child_process subsystem.Issues and PRs related to the child_process subsystem.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Description
Activity
Metadata
Metadata
Assignees
Labels
abortcontrollerIssues and PRs related to the AbortController and AbortSignal APIs.Issues and PRs related to the AbortController and AbortSignal APIs.child_processIssues and PRs related to the child_process subsystem.Issues and PRs related to the child_process subsystem.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
It seems test-child-process-exec-abortcontroller-promisified doesn't cleanup correct as I see 2 running node.js processes afterwards.
On my local windows I see two instances of
node.exe" -e "setInterval(()=>{}, 99)"after this test.ProcessExplorer shows they are in suspended state.
Seems like the actual cause are the last two tests where
AbortSignal.abort(err)is done before callingexecPromisifed.Not sure if this is just at test problem or a real bug.