Skip to content

Avoid calling curl from tests #5174

Closed
Closed
Avoid calling curl from tests#5174
Labels
httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Description

@jbergstroem
jbergstroem
opened on Feb 10, 2016

Adding so I don't forget -- we currently invoke curl in two tests which implicitly pulls it as a dependency:

$ ag "curl " test
test/parallel/test-http-304.js
13:  childProcess.exec('curl -i http://127.0.0.1:' + common.PORT + '/',

test/parallel/test-http-curl-chunk-problem.js
19:  console.log('making curl request');
20:  var cmd = 'curl http://127.0.0.1:' + common.PORT + '/ | ' +

Suggesting we replace this with.. javascript?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions