-
-
Notifications
You must be signed in to change notification settings - Fork 37.2k
zlib upgrade broke known vectors #50138
Copy link
Copy link
Closed as not planned
Labels
dependenciesPRs that add, update, or configure Node.js dependencies.PRs that add, update, or configure Node.js dependencies.invalidIssues and PRs that are invalid.Issues and PRs that are invalid.zlibIssues and PRs related to the zlib module and its compression dependencies.Issues and PRs related to the zlib module and its compression dependencies.
Description
Activity
Metadata
Metadata
Assignees
Labels
dependenciesPRs that add, update, or configure Node.js dependencies.PRs that add, update, or configure Node.js dependencies.invalidIssues and PRs that are invalid.Issues and PRs that are invalid.zlibIssues and PRs related to the zlib module and its compression dependencies.Issues and PRs related to the zlib module and its compression dependencies.
See nodejs/citgm#1011
I suggest to revert the following commits and add unit tests for more known vectors to prevent breaking updates in the future.
cc @alfonsograziano @lpinca @aduh95