-
-
Notifications
You must be signed in to change notification settings - Fork 37.2k
Deprecate AbortSignal on resources that are not actions #48725
Copy link
Copy link
Closed
Labels
abortcontrollerIssues and PRs related to the AbortController and AbortSignal APIs.Issues and PRs related to the AbortController and AbortSignal APIs.httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.streamIssues and PRs related to Node.js streams.Issues and PRs related to Node.js streams.
Description
Activity
Metadata
Metadata
Assignees
Labels
abortcontrollerIssues and PRs related to the AbortController and AbortSignal APIs.Issues and PRs related to the AbortController and AbortSignal APIs.httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.streamIssues and PRs related to Node.js streams.Issues and PRs related to Node.js streams.
We currently have several APIs that support AbortSignals like:
Those APIs are resources and not actions and support
Symbol.disposeSymbol.asyncDispose.Since they are disposables, we should deprecate support for AbortSignal on APIs that are resources and not actions (while keeping AbortSignal on APIs that are actions (e.g. return promises)) and encourage the safe helper we added for
addAbortListeneron those updating our docs.Basically instead of:
We should encourage: