Skip to content

crypto: data race in SecureContext::AddRootCerts? #45743

Closed
#45767
Closed
crypto: data race in SecureContext::AddRootCerts?#45743
#45767
Labels
c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

Description

@bnoordhuis
bnoordhuis
opened on Dec 5, 2022

Possible data race when worker_threads are active?

node/src/crypto/crypto_context.cc

Lines 749 to 751 in 1287530

if (root_cert_store == nullptr) {
root_cert_store = NewRootCertStore();
}

root_cert_store is a static X509_STORE* that is assigned to (and read from) without any kind of synchronization, AFAICT.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions