-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
Node API core consolidation #44071
Copy link
Copy link
Closed as not planned
Labels
node-apiIssues and PRs related to Node-API.Issues and PRs related to Node-API.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
Description
Activity
Metadata
Metadata
Assignees
Labels
node-apiIssues and PRs related to Node-API.Issues and PRs related to Node-API.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
Type
Projects
- StatusShow more project fieldsDone
People are complaining that the node-api core implementation is deviating from node.js core conventions and has a lot of workarounds and non-conventional mechanisms, especially around the finalizers. It makes it harder to maintain the node-api code base.
I'm working with the @nodejs/node-api team on the document https://docs.google.com/document/d/1Bqm05PWQni65FVdSKiaVAkqCAOD9HIfCqG_Y4CAYTbo/edit?usp=sharing to list the problems we are facing and try to figure out what approaches we can apply.
@addaleax thanks for bringing the topic up at #36510 (comment).
Opening this issue to track the progress.