-
-
Notifications
You must be signed in to change notification settings - Fork 37.2k
Can --trace-atomics-wait be removed #42982
Copy link
Copy link
Closed
Labels
feature requestIssues requesting new Node.js features.Issues requesting new Node.js features.never-staleIssues and PRs exempt from automated stale handling.Issues and PRs exempt from automated stale handling.
Description
Activity
Metadata
Metadata
Assignees
Labels
feature requestIssues requesting new Node.js features.Issues requesting new Node.js features.never-staleIssues and PRs exempt from automated stale handling.Issues and PRs exempt from automated stale handling.
What is the problem this feature will solve?
The V8 API hook (
SetAtomicsWaitCallback) to support--trace-atomics-waitis fairly complex and adds maintenance burden. Further the only user of the API is node, and node only uses a subset of the functionality, and only for diagnostic purposes.Is it feasible to remove this diagnostic functionality? Judging by the original commit message the original motivation was maybe to use the hooks to build a deadlock detection system, not just printf diagnostics. It's been 4 years since then, and if no such system has been prototyped and it's not on the roadmap anytime soon, I'd like to deprecate and remove the V8 API.
cc @addaleax
What is the feature you are proposing to solve the problem?
Remove
--trace-atomics-waitWhat alternatives have you considered?
No response