-
-
Notifications
You must be signed in to change notification settings - Fork 37.2k
Improve windows build by pch #37098
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Description
Activity
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.v8 engineIssues and PRs related to the V8 dependency.Issues and PRs related to the V8 dependency.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
This patch bnoordhuis/v8-cmake#43 bring v8 build from 72min to 13min for v8.
I think apply this on our side will make us less suffer dealing with v8 on windows.
Not sure our https://github.com/nodejs/node/blob/master/tools/msvs/pch/v8_pch.h is enabled by default. But our surely take much more time, maybe can fix by add more headers ?
cc @nodejs/v8 @nodejs/platform-windows