-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
Fix Node.js' code coverage/code coverage job #35646
Copy link
Copy link
Closed
Labels
coverageIssues and PRs related to Node.js code coverage support.Issues and PRs related to Node.js code coverage support.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Description
Activity
Metadata
Metadata
Labels
coverageIssues and PRs related to Node.js code coverage support.Issues and PRs related to Node.js code coverage support.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
The problem(s)
1. new file paths are breaking the coverage reporting
File paths for Node.js' own files now have this form
node:/internal/cluster/shared_handle:node:prefix..jsprefix.I will happily fix this problem in the test reporter, but could someone point me towards where these changes were made (@watilde, @guybedford?) -- I want to make sure I link to the change in the reporter codebase.
2. nightly coverage is broken again
Coverage has been broken for several nights in a row. I believe this is due to an unrelated CI/CD upgrade?
Suggested fix
CC: @nodejs/testing