-
-
Notifications
You must be signed in to change notification settings - Fork 37.2k
Drop #ifdef NODE_FIPS_MODE wherever possible #34903
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.cryptoIssues and PRs related to the crypto subsystem.Issues and PRs related to the crypto subsystem.
Description
Activity
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.cryptoIssues and PRs related to the crypto subsystem.Issues and PRs related to the crypto subsystem.
Drop
#ifdef NODE_FIPS_MODEwherever possible, because it does not make sense to guard FIPS code by#ifdef NODE_FIPS_MODE, when this ifdef is immediately followed byFIPS_mode(). It would make sense if theFIPS_mode()is not defined depending on OpenSSL settings, but that is not the case. I believe that removing the guards would help our users to get more precise information about FIPS settings from calls such asnode -p 'crypto.getFips()'. This would also help to resolve this ticket.