Tracking Issue: commit queue issues and feedback #34770

commit-queue can be used to land pull requests. It is still experimental, so when using please remember to check if the Pull Request landed successfully. Please share any failed landings here so we can keep track of issues, our landing process is quite complex and full of edge cases, we'll need to tweak the commit-queue and node-core-utils before we can consider this feature stable.

I'll keep this issue updated with all known issues.

• Commits pushed since last review (buffer: alias UInt ➡️ Uint in buffer methods #34729 (comment))
  • IMO it's fine to request the lander to approve the PR before adding the label
• Missing CI on doc-only changes with successful Actions run (buffer: alias UInt ➡️ Uint in buffer methods #34729 (comment))
• Doesn't work with multiple commits in a PR
• Doesn't work with fixup and squash commits
• Don't land PRs that should be landed manually (manual-land label)
• Can't land DEPXXX (doc: add missing DEP ID for 'new crypto.Certificate()' #34940) (Won't fix, see tools: lint deprecation codes #41992)
• If the newest Jenkins job run is a run that was deleted on Jenkins, the commit queue skips instead of failing
  • But if CI ran on Jenkins and other job was deleted (like CITGM or benchmark), it should succeed
• Should skip if GitHub Actions still running
• Action fails without setting label if local is not sync'ed with remote (which should only happen as a race condition). Should retry instead.
• Land purple
• Don't try to land commits with changes to .github/workflows
• Rewrite in JS
• Try/catch functionality (ensure -failed label is added when something fails)