Skip to content

AsyncLocalStorage potential issue ? #33580

Closed
Closed
AsyncLocalStorage potential issue ?#33580
Labels
async_hooksIssues and PRs related to the async hooks subsystem.docIssues and PRs related to Node.js documentation.questionIssues asking questions about Node.js.

Description

@FranckFreiburger
FranckFreiburger
opened on May 27, 2020

node/lib/async_hooks.js

Line 248 in 9949a2e

resource[this.kResourceStore] = store;

You are using the resource object to store the store whereas the doc state :

In some cases the resource object is reused for performance reasons, it is thus not safe to use it as a key in a WeakMap or add properties to it.

I just wondering if it is ok.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    async_hooksIssues and PRs related to the async hooks subsystem.docIssues and PRs related to Node.js documentation.questionIssues asking questions about Node.js.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions