-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
emit after 'error' #28710
Copy link
Copy link
Closed
Labels
streamIssues and PRs related to Node.js streams.Issues and PRs related to Node.js streams.
Description
Activity
Metadata
Metadata
Assignees
Labels
streamIssues and PRs related to Node.js streams.Issues and PRs related to Node.js streams.
I believe the events allowed to be emitted after
errorshould be rather limited.Based on the test suite I've found the following exceptions:
exit,disconnectandclose, should be ok.unpipe, maybe ok?I've fixed some:
#28709
#28708
#28711
Then there are a lot of possible cases that might need fixing:
https://gist.github.com/ronag/b5728ae5db305abaff9955da5b47a5c9
I've found these by updating
EventEmitter.prototype.emitwith:Is this worth to further look into?