-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
test-ttywrap.writestream.js test always passes #28304
Copy link
Copy link
Closed
Labels
async_hooksIssues and PRs related to the async hooks subsystem.Issues and PRs related to the async hooks subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Description
Activity
Metadata
Metadata
Assignees
Labels
async_hooksIssues and PRs related to the async hooks subsystem.Issues and PRs related to the async hooks subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
In
test/async-hooks/test-ttywrap.writestream.js, there isdelayedOnCloseHandler()which is supposed to check the async-hooks graph. When I run directly with thenodeexecutable, the test fails. When run withtools/test.py, though, the test passes. On my computer, at least, I can change the contents ofdelayedOnCloseHandler()to anything. It can just be athrowstatement. The test will fail as expected when run directly withnodebut will pass when run withtools/test.py.First, can someone else confirm this so that we can label this with
confirmed-bug(or find that they don't experience this behavior in which case I can look more closely at exactly what I'm doing wrong).Second, does anyone know why this would be the case?
@nodejs/testing @nodejs/async_hooks