-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
Track Environment fields in heap snapshot? #26776
Copy link
Copy link
Closed as not planned
Labels
lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.Issues and PRs involving general changes in the lib/ or src/ directories.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
Description
Activity
Metadata
Metadata
Assignees
Labels
lib / srcIssues and PRs involving general changes in the lib/ or src/ directories.Issues and PRs involving general changes in the lib/ or src/ directories.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
At the moment, the Environment fields are not tracked by the heap snapshot (unless they are referenced by some other objects that implements the
MemoryRetainerinterface) - for example, you can't see any of theAliasedBufferin the Environment when looking at a heap snapshot taken after bootstrap. Considering the amount of things we attach to the Environment, it should be pretty useful to track those fields in the heap snapshot instead of keeping them invisible for no particular reason.I am thinking about having Environment implmement
MemoryRetainer, are there any concerns around having it inherit from an abstract class? (considering this is semi-exposed to embedders).