-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
Merge streams handling code for http2 streams & net.Socket #19060
Copy link
Copy link
Closed as not planned
Labels
help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.http2Issues and PRs related to the http2 subsystem.Issues and PRs related to the http2 subsystem.netIssues and PRs related to the net subsystem.Issues and PRs related to the net subsystem.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
Description
Activity
Metadata
Metadata
Assignees
Labels
help wantedIssues that need assistance from volunteers or PRs that need help to proceed.Issues that need assistance from volunteers or PRs that need help to proceed.http2Issues and PRs related to the http2 subsystem.Issues and PRs related to the http2 subsystem.netIssues and PRs related to the net subsystem.Issues and PRs related to the net subsystem.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
Hey :)
It would be great if we could unify all the code from
netandhttp2that is only concerned with pushing data to/from the underlying stream, ideally into a common base class ofnet.SocketandHttp2Stream, so that we could also maybe port some of the other native streams (zlib, fs) to usingStreamBaseon the native side & generally just share a lot of code.This is probably not an easy task, and probably not doable in one pass, because the http2 and net implementations are always just slightly different, but if anybody wants to try to start working on this, feel free to reach out by commenting here.