-
-
Notifications
You must be signed in to change notification settings - Fork 37.2k
C++ coverage broken #18402
Copy link
Copy link
Closed
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Description
Activity
Metadata
Metadata
Assignees
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
https://coverage.nodejs.org/ displays 100 % C++ coverage for commits since 8229fc0...f878f94. I don’t see anything obvious that changed here, but f878f94 changed a sizeable part of node.gyp so that might be it?
/cc @mhdawson @yhwang