-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
Investigate non-ASCII build file path on Windows #17077
Copy link
Copy link
Closed
Labels
addonsIssues and PRs related to native addons.Issues and PRs related to native addons.buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.i18n-apiIssues and PRs related to Node.js internationalization support.Issues and PRs related to Node.js internationalization support.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
Description
Activity
Metadata
Metadata
Assignees
Labels
addonsIssues and PRs related to native addons.Issues and PRs related to native addons.buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.i18n-apiIssues and PRs related to Node.js internationalization support.Issues and PRs related to Node.js internationalization support.windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.
If there's a non-ASCII character in the path to the node directory, the build will break. This issue is only happening on Windows as far as I'm aware (there's a similar bug on POSIX systems, but it was already fixed). See the discussion on #16735 and the errors below:
(https://gist.github.com/anonymous/875aac0ab3e4dfa219854b691f8d3431)