-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
Fix / enable test/addons/dlopen-ping-pong/test.js for AIX #15243
Copy link
Copy link
Closed
Labels
addonsIssues and PRs related to native addons.Issues and PRs related to native addons.aixIssues and PRs related to the AIX platform.Issues and PRs related to the AIX platform.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Description
Activity
Metadata
Metadata
Assignees
Labels
addonsIssues and PRs related to native addons.Issues and PRs related to native addons.aixIssues and PRs related to the AIX platform.Issues and PRs related to the AIX platform.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
PR #12794 introduced a test (test/addons/dlopen-ping-pong/test.js) case that is failing in AIX:
ld: 0711-317 ERROR: Undefined symbol: .dlopen_pongThe root cause is that while building test/addons/dlopen-ping-pong/ping.c it is not able to find the required reference to dlopen_pong that is available in another library built from test/addons/dlopen-ping-pong/binding.cc
The logic is to perform a negative test: (i) make sure that the ping.so does not resolve dlopen_pong under default conditions, (ii) gets resolved when binding.so is loaded through the feature introduced by the PR: ability to customize process.dlopen with standard RTLD_* flags.
With current test logic in AIX, there is no way to go past the linker to make the negative test, as the ping.so itself is not built due to the missing symbol( I guess other platforms where it works perform some sort of lazy loading of symbols under default configurations).
We need to identify and enable that for AIX too. -brtl seems to be a good choice, but need to study its side effects.
Will work with @ezequielgarcia to fix it.