-
-
Notifications
You must be signed in to change notification settings - Fork 37.1k
test: test-http(s)-set-timeout-server.js tests should be more similar #13588
Copy link
Copy link
Closed
Labels
good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.httpsIssues and PRs related to the https subsystem.Issues and PRs related to the https subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Description
Activity
Metadata
Metadata
Assignees
Labels
good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.httpsIssues and PRs related to the https subsystem.Issues and PRs related to the https subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Both of these tests contain unique changes that should copied to the other.
Examples:
test-http-set-timeout-server.js has a
secReceivedcheck inserverResponseTimeoutWithPipeline()that was added to prevent flakiness, but this does not exist in the https counterpart.test-https-set-timeout-server.js utilizes
common.mustCall(),common.mustNotCall(), etc., while the http counterpart still utilizes the old method of checking flags on exit of the process.