Skip to content

benchmark: net/tcp-raw-pipe.js gives wrong data #11972

Closed
#12258
Closed
benchmark: net/tcp-raw-pipe.js gives wrong data#11972
#12258
Labels
benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.netIssues and PRs related to the net subsystem.questionIssues asking questions about Node.js.windowsIssues and PRs related to the Windows platform.

Description

@vsemozhetbyt
vsemozhetbyt
opened on Mar 21, 2017
  • Version: Node.js 8 (node-vee-eight-lkgr) or 7.7.3
  • Platform: Windows 7 x64
  • Subsystem: benchmark

After net suite completed, I've run the compare.R and get the error (translated from Russian):

Error in if (p.value < 0.001) { :
  missing value, need TRUE/FALSE
Calls: ddply ... llply -> loop_apply -> .Call -> <Anonymous> -> .fun
Aborted

The data from net/tcp-raw-pipe.js was like this:

"binary", "filename", "configuration", "rate", "time"
"old", "net\tcp-raw-pipe.js", "dur=5 type=""utf"" len=102400", 0, 5.001326985
"old", "net\tcp-raw-pipe.js", "dur=5 type=""asc"" len=102400", 0, 5.00111327
"old", "net\tcp-raw-pipe.js", "dur=5 type=""buf"" len=102400", 0, 5.001226692
"old", "net\tcp-raw-pipe.js", "dur=5 type=""utf"" len=16777216", 0, 5.012984891
"old", "net\tcp-raw-pipe.js", "dur=5 type=""asc"" len=16777216", 0, 5.000830553
"old", "net\tcp-raw-pipe.js", "dur=5 type=""buf"" len=16777216", 0, 5.001104889
"new", "net\tcp-raw-pipe.js", "dur=5 type=""utf"" len=102400", 0, 5.000816584
"new", "net\tcp-raw-pipe.js", "dur=5 type=""asc"" len=102400", 0, 5.00122753
"new", "net\tcp-raw-pipe.js", "dur=5 type=""buf"" len=102400", 0, 5.000590299
"new", "net\tcp-raw-pipe.js", "dur=5 type=""utf"" len=16777216", 0, 5.0089327
"new", "net\tcp-raw-pipe.js", "dur=5 type=""asc"" len=16777216", 0, 5.000960457
"new", "net\tcp-raw-pipe.js", "dur=5 type=""buf"" len=16777216", 0, 5.008797487
...

If I launch this benchmark separately, the output is:

net\tcp-raw-pipe.js dur=5 type="utf" len=102400: 0
net\tcp-raw-pipe.js dur=5 type="asc" len=102400: 0
net\tcp-raw-pipe.js dur=5 type="buf" len=102400: 0
net\tcp-raw-pipe.js dur=5 type="utf" len=16777216: 0
net\tcp-raw-pipe.js dur=5 type="asc" len=16777216: 0
net\tcp-raw-pipe.js dur=5 type="buf" len=16777216: 0

Is this in my environment only? Can anybody reproduce?

Update: now this benchmark throws on Windows due to this check (see #12030).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    benchmarkIssues and PRs related to Node.js benchmarks and benchmarking infrastructure.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.netIssues and PRs related to the net subsystem.questionIssues asking questions about Node.js.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions