-
-
Notifications
You must be signed in to change notification settings - Fork 37.2k
New error system in WHATWG URL implementation #11299
Copy link
Copy link
Closed
Labels
discussIssues opened for discussion and feedback.Issues opened for discussion and feedback.errorsIssues and PRs related to JavaScript errors originating in Node.js core.Issues and PRs related to JavaScript errors originating in Node.js core.whatwg-urlIssues and PRs related to the WHATWG URL implementation.Issues and PRs related to the WHATWG URL implementation.
Description
Activity
Metadata
Metadata
Assignees
Labels
discussIssues opened for discussion and feedback.Issues opened for discussion and feedback.errorsIssues and PRs related to JavaScript errors originating in Node.js core.Issues and PRs related to JavaScript errors originating in Node.js core.whatwg-urlIssues and PRs related to the WHATWG URL implementation.Issues and PRs related to the WHATWG URL implementation.
Just realized according to the spec the errors thrown from our WHATWG URL implementation should be ECMAScript error objects, but
internal/errors.jsprovides errors subclassing those error classes, so does that mean our WHATWG URL implementation cannot be migrated to this new error system, or do we have a way to work around that?refs: #11220
refs: #11273
cc @nodejs/url