Skip to content

Commit ef4b6bf

Browse files
abmusseaduh95
abmusse
authored and
aduh95
committed
test: set type=none on IBM i for empty source
addon targets. openssl-binding, openssl-get-ssl-ctx, openssl-providers, and zlib-binding all exclude their sources on IBM i because the platform ships OpenSSL and zlib as system libraries. The binding.gyp condition leaves the target with no sources but still of type 'loadable_module', which causes gyp to generate a full solink_module COPY rule in the generated Makefile. With gcc-12, the compiler exits 1 on empty input so gmake stops at the link step and build_addons.py skips the addon non fatally. With clang-21, the compiler exits 0 on empty input and writes no output file. The linker driver then runs llvm-nm internally as a post-link step to generate the .exp symbol export file, finds no output and aborts with: llvm-nm: error: a.out: No such file or directory The fix is to declare the target as type 'none' when on IBM i. The gyp make generator produces only a touch-stamp rule for 'none' targets no solink_module, no COPY, no .node output is ever expected. build_addons.py sees exit 0 and run-ci continues. Signed-off-by: Abdirahim Musse <33973272+abmusse@users.noreply.github.com> PR-URL: #65545 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
1 parent 837ce2c commit ef4b6bf

4 files changed

Lines changed: 12 additions & 0 deletions

File tree

‎test/addons/openssl-binding/binding.gyp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
'aix_variant_name': '<!(uname -s)',
1313
},
1414
'conditions': [
15+
[ '"<(aix_variant_name)"=="OS400"', { # OS400 (IBM i): no sources, skip link
16+
'type': 'none',
17+
}],
1518
[ '"<(aix_variant_name)"!="OS400"', { # Not `OS400`(IBM i)
1619
'sources': ['binding.cc'],
1720
'include_dirs': ['../../../deps/openssl/openssl/include'],

‎test/addons/openssl-get-ssl-ctx/binding.gyp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
'aix_variant_name': '<!(uname -s)',
1313
},
1414
'conditions': [
15+
[ '"<(aix_variant_name)"=="OS400"', { # OS400 (IBM i): no sources, skip link
16+
'type': 'none',
17+
}],
1518
[ '"<(aix_variant_name)"!="OS400"', { # Not `OS400`(IBM i)
1619
'sources': ['binding.cc'],
1720
'include_dirs': ['../../../deps/openssl/openssl/include'],

‎test/addons/openssl-providers/binding.gyp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
'aix_variant_name': '<!(uname -s)',
1313
},
1414
'conditions': [
15+
[ '"<(aix_variant_name)"=="OS400"', { # OS400 (IBM i): no sources, skip link
16+
'type': 'none',
17+
}],
1518
[ '"<(aix_variant_name)"!="OS400"', { # Not `OS400`(IBM i)
1619
'sources': ['binding.cc'],
1720
'include_dirs': ['../../../deps/openssl/openssl/include'],

‎test/addons/zlib-binding/binding.gyp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
'aix_variant_name': '<!(uname -s)',
1010
},
1111
'conditions': [
12+
[ '"<(aix_variant_name)"=="OS400"', { # OS400 (IBM i): no sources, skip link
13+
'type': 'none',
14+
}],
1215
[ '"<(aix_variant_name)"!="OS400"', { # Not `OS400`(IBM i)
1316
'sources': ['binding.cc'],
1417
'include_dirs': ['../../../deps/zlib'],

0 commit comments

Comments
 (0)