Skip to content

v6: remove Profile.getSamlResponseXml() #424

Description

@cjbarth

Profile.getSamlResponseXml() hands the caller the raw, unsigned response XML:

profile.getSamlResponseXml = () => samlResponseXml;

AGENTS.md's first invariant is "trust only the bytes that were signed", and this is a public
accessor that returns the bytes that were not. Anything a caller decides on the strength of
what it returns is a decision made on attacker-controlled input — the signature-wrapping
shape the rest of the library is built to prevent.

AGENTS.md names it as a known debt, alongside processValidlySignedAssertionAsync taking the
same unsigned XML as a parameter.

Remove it in the next major. Callers who need the verified document should get it from
getVerifiedXml().

5.2.0 marks it @deprecated so it surfaces in the consumer's editor first.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions