From 03c6ffc8b2b377550505dae2955540ddd4315ae4 Mon Sep 17 00:00:00 2001 From: "Nir.Tal" Date: Sat, 3 Aug 2024 17:03:13 +0300 Subject: [PATCH 1/7] fix: fix run --- .github/workflows/nightly.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 9c9634aa1..602a58da3 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -62,7 +62,7 @@ jobs: exit_code=0 { if [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then - pytest_args="${{ github.event.inputs.pytest_command }}" + pytest_args='-m "not devRun"' else pytest_args='-m "not devRun"' fi From f47ad133e1287fa3c4e1ac844985aefabe0f3b8f Mon Sep 17 00:00:00 2001 From: "Nir.Tal" Date: Sun, 4 Aug 2024 08:13:42 +0300 Subject: [PATCH 2/7] fix: fix run --- .github/workflows/nightly.yml | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 602a58da3..e877d2b80 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -57,23 +57,23 @@ jobs: run: npx playwright install --with-deps - name: Run Tests run: | - mkdir -p exit-code allure-results - source .venv/bin/activate - exit_code=0 - { - if [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then - pytest_args='-m "not devRun"' - else - pytest_args='-m "not devRun"' - fi - xvfb-run pytest $pytest_args \ - --base-url ${{ vars.BASE_URL }} \ - --splits ${{ github.event.inputs.machine_count || 2 }} \ - --group ${{ matrix.group }} - } || { - exit_code=$? - } - echo $exit_code > exit-code/shard_${{ matrix.group }}.txt + echo "mkdir -p exit-code allure-results" + echo "source .venv/bin/activate" + echo "exit_code=0" + echo "{" + echo " if [[ \"${{ github.event_name }}\" == \"workflow_dispatch\" ]]; then" + echo " pytest_args='-m \"not devRun\"'" + echo " else" + echo " pytest_args='-m \"not devRun\"'" + echo " fi" + echo " xvfb-run pytest \$pytest_args \\" + echo " --base-url ${{ vars.BASE_URL }} \\" + echo " --splits ${{ github.event.inputs.machine_count || 2 }} \\" + echo " --group ${{ matrix.group }}" + echo "} || {" + echo " exit_code=\$?" + echo "}" + echo "echo \$exit_code > exit-code/shard_${{ matrix.group }}.txt" - name: Upload test results and artifacts uses: actions/upload-artifact@v4.3.3 with: From 1f9d258d26b61895f417321290972a6ad99259b1 Mon Sep 17 00:00:00 2001 From: "Nir.Tal" Date: Sun, 4 Aug 2024 08:38:16 +0300 Subject: [PATCH 3/7] fix: fix run --- .github/workflows/nightly.yml | 35 ++++++++++++++++++----------------- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index e877d2b80..12c9f31ac 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -57,23 +57,24 @@ jobs: run: npx playwright install --with-deps - name: Run Tests run: | - echo "mkdir -p exit-code allure-results" - echo "source .venv/bin/activate" - echo "exit_code=0" - echo "{" - echo " if [[ \"${{ github.event_name }}\" == \"workflow_dispatch\" ]]; then" - echo " pytest_args='-m \"not devRun\"'" - echo " else" - echo " pytest_args='-m \"not devRun\"'" - echo " fi" - echo " xvfb-run pytest \$pytest_args \\" - echo " --base-url ${{ vars.BASE_URL }} \\" - echo " --splits ${{ github.event.inputs.machine_count || 2 }} \\" - echo " --group ${{ matrix.group }}" - echo "} || {" - echo " exit_code=\$?" - echo "}" - echo "echo \$exit_code > exit-code/shard_${{ matrix.group }}.txt" + mkdir -p exit-code allure-results + source .venv/bin/activate + exit_code=0 + { + if [[ "${{ github.event_name }}" == "workflow_dispatch" ]]; then + pytest_args='-m "not devRun"' + else + pytest_args='-m "not devRun"' + fi + echo $pytest_args + xvfb-run pytest $pytest_args \ + --base-url ${{ vars.BASE_URL }} \ + --splits ${{ github.event.inputs.machine_count || 2 }} \ + --group ${{ matrix.group }} + } || { + exit_code=$? + } + echo $exit_code > exit-code/shard_${{ matrix.group }}.txt - name: Upload test results and artifacts uses: actions/upload-artifact@v4.3.3 with: From c6f74eeb76cb5f7427b4c525ea14144881a3abab Mon Sep 17 00:00:00 2001 From: "Nir.Tal" Date: Sun, 4 Aug 2024 08:49:58 +0300 Subject: [PATCH 4/7] fix: fix run --- .github/workflows/nightly.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 12c9f31ac..f7daad5de 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -66,7 +66,8 @@ jobs: else pytest_args='-m "not devRun"' fi - echo $pytest_args + # Print the full pytest command + echo "Running command: xvfb-run pytest $pytest_args --base-url ${{ vars.BASE_URL }} --splits ${{ github.event.inputs.machine_count || 2 }} --group ${{ matrix.group }}" xvfb-run pytest $pytest_args \ --base-url ${{ vars.BASE_URL }} \ --splits ${{ github.event.inputs.machine_count || 2 }} \ From 68d31b9e83d3fecef8fe84e11c87db8ef2a87b87 Mon Sep 17 00:00:00 2001 From: "Nir.Tal" Date: Sun, 4 Aug 2024 08:54:48 +0300 Subject: [PATCH 5/7] fix: fix run --- .github/workflows/nightly.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index f7daad5de..a05dbd93e 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -71,7 +71,8 @@ jobs: xvfb-run pytest $pytest_args \ --base-url ${{ vars.BASE_URL }} \ --splits ${{ github.event.inputs.machine_count || 2 }} \ - --group ${{ matrix.group }} + --group ${{ matrix.group }} \ + --collect-only -v } || { exit_code=$? } From 6611448b394cd7f53c0eaa1e9f9952a0bb62102f Mon Sep 17 00:00:00 2001 From: "Nir.Tal" Date: Sun, 4 Aug 2024 10:27:59 +0300 Subject: [PATCH 6/7] fix: fix run --- .github/workflows/nightly.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index a05dbd93e..7dae518a7 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -68,7 +68,7 @@ jobs: fi # Print the full pytest command echo "Running command: xvfb-run pytest $pytest_args --base-url ${{ vars.BASE_URL }} --splits ${{ github.event.inputs.machine_count || 2 }} --group ${{ matrix.group }}" - xvfb-run pytest $pytest_args \ + xvfb-run pytest -m "not devRun" \ --base-url ${{ vars.BASE_URL }} \ --splits ${{ github.event.inputs.machine_count || 2 }} \ --group ${{ matrix.group }} \ From 6cf4f6cb156b4b423a3bf0a627b8e638695a536f Mon Sep 17 00:00:00 2001 From: "Nir.Tal" Date: Sun, 4 Aug 2024 10:28:14 +0300 Subject: [PATCH 7/7] fix: fix run --- .github/workflows/nightly.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index 7dae518a7..2c93f4d96 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -66,8 +66,6 @@ jobs: else pytest_args='-m "not devRun"' fi - # Print the full pytest command - echo "Running command: xvfb-run pytest $pytest_args --base-url ${{ vars.BASE_URL }} --splits ${{ github.event.inputs.machine_count || 2 }} --group ${{ matrix.group }}" xvfb-run pytest -m "not devRun" \ --base-url ${{ vars.BASE_URL }} \ --splits ${{ github.event.inputs.machine_count || 2 }} \