Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

loadContents function will fail when empty and non-empty lu or qna files list are provided #924

Description

@feich-ms

Versions

bf-cli master branch
Composer reported issue since they have empty lu or qna files in many scenarios.

Describe the bug

When users call loadContents function in builder.ts of lubuild or qnabuild, it will not load files and create dialogs assets correctly when parsing empty files. The root cause it that luMerger will throw exception if we don't filter those empty files. The fix is straightforward, just filter empty files before calling luMerger and avoid creating recognizers for those empty files.

To Reproduce

Steps to reproduce the behavior:

  1. use luis build or qnamaker build cli
  2. use one non-empty and one empty files as input
  3. see the build results, you will find the non-empty file is not published

Expected behavior

loadContents can handle empty files correctly.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

[bug]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

R10Release 10 - August 17th, 2020lunon luis api commands

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions