Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

[bf luis:generate:cs] Disparity with bf luis:generate:ts to try/catch errors #1050

Description

Versions

What CLI version are you using.
4.10.1 or master branch

What Nodejs version are you using
12.14.1

What command-line interpreters are you using
bf luis:generate:cs

What OS are you using
Windows 10

Describe the bug

There is a disparity between the bf luis:generate:cs and the bf luis:generate:ts commands. This cause that the :cs is throwing a generic error because it's not catching correctly the error as they are not wrapped in a try/catch sentence like in the :ts.

To Reproduce

  1. See async run() of bf luis:generate:cs.
  2. See async run() of bf luis:generate:ts.
  3. Check the differences of wrapping in a try/catch sentence.

Expected behavior

The command should throw the same error like bf luis:generate:ts, and not a generic one wrapping the process in a try/catch sentence.

Screenshots

Executing bf luis:generate:cs in the Virtual Assistant root folder

image

Executing bf luis:generate:ts in the Virtual Assistant root folder

image

cs.ts vs ts.ts code

image

Additional context

See microsoft/botframework-solutions#3693

[bug]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.P1Painful if we don't fix, won't block releasingcustomer-replied-toIndicates that the team has replied to the issue reported by the customer. Do not delete.customer-reportedIssue is created by anyone that is not a collaborator in the repository.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions