Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

[PORT] Fixes Unauthorized error when calling ContinueConversation #730

Description

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4348

Fixes #4347

Fixes Unauthorized error when ContinueConversation is called on a bot app service instance that didn't originate the skill request.

  • Updated code in BotFrameworkAdapter.ContinueConversation() so it always adds the activity.ServiceUrl to TrustedHostNames if the request has been authorized and it has an app ID (this will work for skills and other proactive messages)
  • Made TrustedHostNames in AppCredentials internal and added InternalsVisibleTo directive to Microsoft.BotConnector so we can access it and assert the state of the state in tests.
  • Cleaned up some async warnings in BotFrameworkAdapterTests
  • Added additional logging to AppCredentials to help troubleshoot this issue in the future.

Changed projects

  • Microsoft.Bot.Builder
  • Microsoft.Bot.Connector
  • Microsoft.Bot.Builder.Tests

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Area: AuthenticationThe issue is related to authenticating users (SSO, OAuth, etc.)P0Must Fix. Release-blocker

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions