Skip to content

Various improvements in finance.py #3094

Description

@montefra

While working on #3060, I've added a private function to check the input of some other functions.

I suggest:

  • Improve (some) docstring: e.g. in some function there is information about the input structure in the code comments and this should be moved into the docstring
  • Avoid using buildin for variable names
  • Improve loops: e.g. avoid use zip(xrange(len(a)), a, ...) when zip(itertools.count(), a, ...) or enumerate(a) would suffice

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions