Skip to content

Commit facd1ba

Browse files
liujupingliujuping
committed
chore: fix npm package VERSION_PLACEHOLDER is not defined
1 parent f30db20 commit facd1ba

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎packages/engine/build.plugin.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ module.exports = ({ context, onGetWebpackConfig }) => {
2424
config
2525
.plugin('define')
2626
.use(context.webpack.DefinePlugin, [{
27-
VERSION_PLACEHOLDER: JSON.stringify(version),
27+
VERSION_PLACEHOLDER: version,
2828
}]);
2929
config.plugins.delete('hot');
3030
config.devServer.hot(false);

‎packages/engine/src/engine-core.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ export {
177177

178178
let engineInited = false;
179179
// @ts-ignore webpack Define variable
180-
export const version = VERSION_PLACEHOLDER;
180+
export const version = 'VERSION_PLACEHOLDER';
181181
engineConfig.set('ENGINE_VERSION', version);
182182
export async function init(
183183
container?: HTMLElement,

‎packages/ignitor/build.plugin.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ module.exports = ({ context, onGetWebpackConfig }) => {
1414
config
1515
.plugin('define')
1616
.use(context.webpack.DefinePlugin, [{
17-
VERSION_PLACEHOLDER: JSON.stringify(version),
17+
VERSION_PLACEHOLDER: version,
1818
}]);
1919
config.plugins.delete('hot');
2020
config.devServer.hot(false);

0 commit comments

Comments
 (0)