Skip to content

bug: tutorials broken, graphframes CLI missing click, py7zr and requests as dependencies #884

Description

@rjurney

Describe the bug

The released package doesn't have any extras (which confuses me, I thought they were defined in pyproject.toml?) and the tutorials require the tutorials extra... I can't install pip install graphframes-py[tutorials] or graphframes[all] and when I pip install the package, I get the following error when I run the graphframes CLI required for the tutorials because click, py7zr and requests are missing:

pip install graphframes-py

Collecting graphframes-py
  Using cached graphframes_py-0.12.1-py3-none-any.whl.metadata
Using cached graphframes_py-0.12.1-py3-none-any.whl (73 kB)
Installing collected packages: graphframes-py
Successfully installed graphframes-py-0.12.1
graphframes

Traceback (most recent call last):
  File "/Users/rjurney/anaconda3/envs/test/bin/graphframes", line 3, in <module>
    from graphframes.console import main
  File "/Users/rjurney/anaconda3/envs/test/lib/python3.12/site-packages/graphframes/console.py", line 1, in <module>
    import click
ModuleNotFoundError: No module named 'click'

This is bad :( Once you run pip install click py7zr requests you can run graphframes and it works.

To Reproduce

Steps to reproduce the behavior:

  1. pip install graphframes-py pyspark
  2. graphframes
  3. See error

Expected behavior

  1. pip install graphframes-py[tutorials] or pip install graphframes-py[all]
  2. graphframes
Usage: graphframes [OPTIONS] COMMAND [ARGS]...

  GraphFrames CLI: a collection of commands for graphframes.

Options:
  --help  Show this message and exit.

Commands:
  stackexchange  Download Stack Exchange archive for a given SUBDOMAIN.

System [please complete the following information]:

  • OS: e.g. [Ubuntu 18.04] Mac OS X
  • Python Version (if applied): [e.g. Python 3.8] 3.12
  • Spark / PySpark version: [e.g. PySpark 3.5.1] 4.1.3
  • GraphFrames version: [e.g. graphframes-0.9.0] 0.12.1

Component

  • Scala Core Internal
  • Scala API
  • Spark Connect Plugin
  • [*] PySpark Classic
  • [*] PySpark Connect

Additional context

Need to release packages with extras

Are you planning on creating a PR?

  • [*] I'm willing to make a pull-request

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions