PR #6290 blacklisted a number of conformance tests because we do not currently support the usecases they support: - `get-*` tests (because we use `BatchGetDocuments` API rather than the `GetDocument` API. - `listen-*` tests exercise the "watch" features (since landed in PR #6191). - `update_paths-*` tests (they've been excluded forever, with a note that Python lacked the support). - Tests involving unimplemented / incorrectly implemented "transforms" (`DELETE`, `ARRAY_REMOVE`, `ARRAY_UNION`). - `query-*` tests have been (inadvertently) skipped since being copied in from `google-cloud-common` in PR #5351). This is a tracking issue for removing those skips / blacklist entries: - [x] Update `Document.get` to use the `GetDocument` API, and re-enable the (one) `get-basic.textproto` test. (#6534) - [x] Fix the support for the `DELETE` transform (one failing test) and enable those tests. (#6559) - [x] Figure out how to support the `ARRAY_REMOVE` transform, and enable those tests. (#6651) - [x] Figure out how to support the `ARRAY_UNION` transform, and enable those tests. (#6651) - [x] Enable the `query-*` tests and make changes needed for them to pass. (#6839) - [x] Enable the `listen-*` tests and make changes needed for them to pass. (#6935) Not in scope: ~~- Figure how to support the "update with paths" use case, and enable those tests.~~
PR #6290 blacklisted a number of conformance tests because we do not currently support the usecases they support:
get-*tests (because we useBatchGetDocumentsAPI rather than theGetDocumentAPI.listen-*tests exercise the "watch" features (since landed in PR Firestore: add Watch Support #6191).update_paths-*tests (they've been excluded forever, with a note that Python lacked the support).DELETE,ARRAY_REMOVE,ARRAY_UNION).query-*tests have been (inadvertently) skipped since being copied in fromgoogle-cloud-commonin PR Re-sync with .proto / .textproto files from google-cloud-common. #5351).This is a tracking issue for removing those skips / blacklist entries:
Document.getto use theGetDocumentAPI, and re-enable the (one)get-basic.textprototest. (Firestore: refactor 'Document.get' to use the 'GetDocument' API. #6534)DELETEtransform (one failing test) and enable those tests. (Firestore: fix delete conformance #6559)ARRAY_REMOVEtransform, and enable those tests. (Firestore: add support for 'ArrayRemove' / 'ArrayUnion' transforms #6651)ARRAY_UNIONtransform, and enable those tests. (Firestore: add support for 'ArrayRemove' / 'ArrayUnion' transforms #6651)query-*tests and make changes needed for them to pass. (Firestore: add driver for query conformance tests. #6839)listen-*tests and make changes needed for them to pass. (Firestore: implement listen conformance #6935)Not in scope:
- Figure how to support the "update with paths" use case, and enable those tests.