Skip to content

Commit 3a13334

Browse files
livecodeianlivecodeian
committed
[ CID 16296 ] libgraphics: legacygradients.cpp: Uninitialized scalar variable in MCGradientFillCreateCombiner
Fixed by exiting function on unrecognised gradient function (this is the case that results in t_kind remaining uninitialized).
1 parent 069fe32 commit 3a13334

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎libgraphics/src/legacygradients.cpp‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -826,7 +826,11 @@ MCGradientAffineCombiner *MCGradientFillCreateCombiner(MCGGradientRef p_gradient
826826
case kMCGLegacyGradientSqrtXY:
827827
t_kind = kMCGradientKindSqrtXY;
828828
break;
829-
}
829+
830+
default:
831+
// Unrecognised gradient type
832+
return nil;
833+
}
830834

831835
if (!MCMemoryNewArray(p_gradient_ref -> ramp_length, (*t_combiner)->ramp))
832836
return nil;

0 commit comments

Comments
 (0)