Skip to content

Commit 42a7ba7

Browse files
authored
Add the default serverName to SentryOptions and use it in MainEventProcessor (getsentry/sentry-android#279)
1 parent ef59cd8 commit 42a7ba7

3 files changed

Lines changed: 30 additions & 1 deletion

File tree

sentry-core/src/main/java/io/sentry/core/MainEventProcessor.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,9 @@ private void processNonCachedEvent(SentryEvent event) {
6767
if (event.getEnvironment() == null) {
6868
event.setEnvironment(options.getEnvironment());
6969
}
70-
70+
if (event.getServerName() == null) {
71+
event.setServerName(options.getServerName());
72+
}
7173
if (event.getDist() == null) {
7274
event.setDist(options.getDist());
7375
}

sentry-core/src/main/java/io/sentry/core/SentryOptions.java

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,9 @@ public class SentryOptions {
146146
*/
147147
private boolean attachStacktrace;
148148

149+
/** The server name used in the Sentry messages. */
150+
private String serverName;
151+
149152
/**
150153
* Adds an event processor
151154
*
@@ -632,6 +635,24 @@ public void setAttachThreads(boolean attachThreads) {
632635
this.attachThreads = attachThreads;
633636
}
634637

638+
/**
639+
* Gets the default server name to be used in Sentry events.
640+
*
641+
* @return the default server name or null if none set
642+
*/
643+
public @Nullable String getServerName() {
644+
return serverName;
645+
}
646+
647+
/**
648+
* Sets the default server name to be used in Sentry events.
649+
*
650+
* @param serverName the default server name or null if none should be used
651+
*/
652+
public void setServerName(@Nullable String serverName) {
653+
this.serverName = serverName;
654+
}
655+
635656
/** The BeforeSend callback */
636657
public interface BeforeSendCallback {
637658

sentry-core/src/test/java/io/sentry/core/MainEventProcessorTest.kt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ class MainEventProcessorTest {
1616
release = "release"
1717
environment = "environment"
1818
dist = "dist"
19+
serverName = "server"
1920
}
2021
fun getSut(attachThreads: Boolean = true): MainEventProcessor {
2122
sentryOptions.isAttachThreads = attachThreads
@@ -48,6 +49,7 @@ class MainEventProcessorTest {
4849
assertEquals("release", event.release)
4950
assertEquals("environment", event.environment)
5051
assertEquals("dist", event.dist)
52+
assertEquals("server", event.serverName)
5153
assertTrue(event.threads.first { t -> t.id == crashedThread.id }.isCrashed)
5254
}
5355

@@ -58,12 +60,14 @@ class MainEventProcessorTest {
5860
event.dist = "eventDist"
5961
event.environment = "eventEnvironment"
6062
event.release = "eventRelease"
63+
event.serverName = "eventServerName"
6164

6265
event = sut.process(event, null)
6366

6467
assertEquals("eventRelease", event.release)
6568
assertEquals("eventEnvironment", event.environment)
6669
assertEquals("eventDist", event.dist)
70+
assertEquals("eventServerName", event.serverName)
6771
}
6872

6973
@Test
@@ -75,6 +79,8 @@ class MainEventProcessorTest {
7579

7680
assertNull(event.release)
7781
assertNull(event.environment)
82+
assertNull(event.dist)
83+
assertNull(event.serverName)
7884
assertNull(event.threads)
7985
}
8086

0 commit comments

Comments
 (0)