-
-
Notifications
You must be signed in to change notification settings - Fork 135
Add an async context data test for @fedify/express #855
Copy link
Copy link
Labels
component/integrationWeb framework integrationWeb framework integrationcomponent/testingTesting utilities (@fedify/testing)Testing utilities (@fedify/testing)difficulty/beginnerBeginner friendlyBeginner friendlygood first issueGood for newcomersGood for newcomersintegration/expressExpress.js integration (@fedify/express)Express.js integration (@fedify/express)
Description
Activity
Metadata
Metadata
Assignees
Labels
component/integrationWeb framework integrationWeb framework integrationcomponent/testingTesting utilities (@fedify/testing)Testing utilities (@fedify/testing)difficulty/beginnerBeginner friendlyBeginner friendlygood first issueGood for newcomersGood for newcomersintegration/expressExpress.js integration (@fedify/express)Express.js integration (@fedify/express)
Type
Fields
Priority
Low
Effort
Low
@fedify/express accepts both synchronous and asynchronous context data factories. The async path should be covered so applications can safely load context from sessions or databases.
Add a test in packages/express/src/index.test.ts that verifies
integrateFederation()waits for an asynccontextDataFactoryand passes the resolved value tofederation.fetch().Suggested check:
mise run check-each express.