Skip to content

DockerCmdExecFactoryImpl change uri inside DockerClientConfig during init ... #456

Description

@mbaechler

and this breaks support for unix socket.

The problem is that once you called DockerCmdExecFactoryImpl.init() once with a configuration containing uri : unix:///var/run/docker.sock , you can't reuse the configuration for a second DockerCmdExecFactoryImpl instance, because the new value set into DockerClientConfig is not supported but init() method.

The obvious fix is to prevent configuration from being modified.

I'll propose a PR soon.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions