Currently if you call withHostConfig method (
|
public CreateContainerCmd withHostConfig(HostConfig hostConfig) { |
) you are unsetting previous values. Since you can set then directly from CreateBuilder or withHostConfig it seems not a good decision to override them so I suggest that instead of overriding it simply appends.
The other option is that all options that appear from hostconfig can be also set from Container builder. For example readOnlyRootFs cannot be set
Currently if you call withHostConfig method (
docker-java/src/main/java/com/github/dockerjava/core/command/CreateContainerCmdImpl.java
Line 450 in 9b29ba7
The other option is that all options that appear from hostconfig can be also set from Container builder. For example readOnlyRootFs cannot be set