Skip to content

Commit 3de20e4

Browse files
committed
Tests: add tests for convert_loader_name()
1 parent 5bb5e13 commit 3de20e4

3 files changed

Lines changed: 35 additions & 2 deletions

File tree

commands/preprocess.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,8 @@ def add_file_to_rename_map(rename_map, dir, fn, new_fn):
8787
return
8888
rename_map.append((dir, fn, new_fn))
8989

90+
# Converts complex URL to resources supplied by MediaWiki loader to a simplified
91+
# name
9092
def convert_loader_name(fn):
9193
if re.search("modules=site&only=scripts", fn):
9294
return "site_scripts.js"
@@ -99,8 +101,8 @@ def convert_loader_name(fn):
99101
elif re.search("modules=.*ext.*&only=styles", fn):
100102
return "ext.css"
101103
else:
102-
print("Loader file " + fn + " does not match any known files")
103-
sys.exit(1)
104+
raise Exception('Loader file {0} does not match any known files'\
105+
.format(fn))
104106

105107
def find_files_to_be_renamed(root):
106108
# Returns a rename map: array of tuples each of which contain three strings:

tests/__init__.py

Whitespace-only changes.

tests/test_preprocess.py

Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
#!/usr/bin/env python3
2+
# -*- coding: utf-8 -*-
3+
from commands.preprocess import *
4+
import unittest
5+
6+
class TestConvertLoaderName(unittest.TestCase):
7+
def test_convert_loader_name(self):
8+
url = 'http://en.cppreference.com/mwiki/load.php?debug=false&lang=en&\
9+
modules=site&only=scripts&skin=cppreference2&*'
10+
self.assertEqual('site_scripts.js', convert_loader_name(url))
11+
12+
url = 'http://en.cppreference.com/mwiki/load.php?debug=false&lang=en&\
13+
modules=site&only=styles&skin=cppreference2&*'
14+
self.assertEqual('site_modules.css', convert_loader_name(url))
15+
16+
url = 'http://en.cppreference.com/mwiki/load.php?debug=false&lang=en&\
17+
modules=skins.cppreference2&only=scripts&skin=cppreference2&*'
18+
self.assertEqual('skin_scripts.js', convert_loader_name(url))
19+
20+
url = 'http://en.cppreference.com/mwiki/load.php?debug=false&lang=en&\
21+
modules=startup&only=scripts&skin=cppreference2&*'
22+
self.assertEqual('startup_scripts.js', convert_loader_name(url))
23+
24+
url = 'http://en.cppreference.com/mwiki/load.php?debug=false&lang=en&\
25+
modules=ext.gadget.ColiruCompiler%2CMathJax%7Cext.rtlcite%7Cmediawiki.\
26+
legacy.commonPrint%2Cshared%7Cskins.cppreference2&only=styles&skin=\
27+
cppreference2&*'
28+
self.assertEqual('ext.css', convert_loader_name(url))
29+
30+
with self.assertRaises(Exception):
31+
convert_loader_name('')

0 commit comments

Comments
 (0)