-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Expand file tree
/
Copy patherrors_test.go
More file actions
311 lines (287 loc) · 8.64 KB
/
Copy patherrors_test.go
File metadata and controls
311 lines (287 loc) · 8.64 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
package templatebuilder_test
import (
"strings"
"testing"
"github.com/stretchr/testify/require"
"github.com/coder/coder/v2/coderd/templatebuilder"
)
func TestClassifyProvisionerError(t *testing.T) {
t.Parallel()
t.Run("NetworkErrors", func(t *testing.T) {
t.Parallel()
tests := []struct {
name string
jobError string
logs []string
}{
{
name: "DNSFailure",
jobError: "init failed",
logs: []string{"Error: Failed to query available provider packages", "dial tcp: lookup registry.terraform.io: no such host"},
},
{
name: "ConnectionRefused",
jobError: "terraform init: connection refused",
logs: nil,
},
{
name: "IOTimeout",
jobError: "context deadline exceeded",
logs: []string{"dial tcp 1.2.3.4:443: i/o timeout"},
},
{
name: "TLSTimeout",
jobError: "init error",
logs: []string{"net/http: TLS handshake timeout"},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
result := templatebuilder.ClassifyProvisionerError(tc.jobError, tc.logs)
require.Contains(t, result, "unreachable from your provisioner")
})
}
})
t.Run("NetworkTakesPrecedenceOverAuth", func(t *testing.T) {
t.Parallel()
// When both network and auth patterns appear, network wins
// (checked first).
result := templatebuilder.ClassifyProvisionerError(
"connection refused",
[]string{"AccessDenied: check credentials"},
)
require.Contains(t, result, "unreachable from your provisioner")
})
t.Run("AuthErrors", func(t *testing.T) {
t.Parallel()
tests := []struct {
name string
jobError string
logs []string
}{
{
name: "AWSNoCredentials",
jobError: "terraform plan: exit status 1",
logs: []string{
"Initializing the backend...",
"Initializing provider plugins...",
"Error: No valid credential sources found",
"",
" on main.tf line 10, in provider \"aws\":",
" 10: region = \"us-east-1\"",
},
},
{
name: "GCPDefaultCredentials",
jobError: "terraform plan: exit status 1",
logs: []string{
"Error: could not find default credentials",
},
},
{
name: "AzureAuthFailure",
jobError: "terraform plan: exit status 1",
logs: []string{"Error: AuthorizationFailed for subscription"},
},
{
name: "CaseInsensitive",
jobError: "terraform plan: exit status 1",
logs: []string{"Error: ACCESSDENIED on resource"},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
result := templatebuilder.ClassifyProvisionerError(tc.jobError, tc.logs)
require.Contains(t, result, "Cloud provider authentication failed")
})
}
})
t.Run("AuthErrorNoLogsNoDanglingNewlines", func(t *testing.T) {
t.Parallel()
// Auth pattern in jobError with nil logs should not produce
// trailing newlines.
result := templatebuilder.ClassifyProvisionerError(
"AccessDenied: you are not allowed",
nil,
)
require.Contains(t, result, "Cloud provider authentication failed")
require.False(t, strings.HasSuffix(result, "\n"), "should not end with newline")
})
t.Run("UnrecognizedErrorIncludesLogs", func(t *testing.T) {
t.Parallel()
result := templatebuilder.ClassifyProvisionerError(
"terraform plan: exit status 1",
[]string{
"Initializing the backend...",
"Initializing provider plugins...",
"",
"Error: Unsupported block type",
"",
" on main.tf line 5, in resource \"null_resource\" \"test\":",
" 5: invalid_block {",
},
)
require.Contains(t, result, "terraform plan: exit status 1")
require.Contains(t, result, "Unsupported block type")
require.Contains(t, result, "on main.tf line 5")
})
t.Run("UnrecognizedErrorNoLogs", func(t *testing.T) {
t.Parallel()
result := templatebuilder.ClassifyProvisionerError(
"terraform plan: exit status 1",
nil,
)
require.Equal(t, "terraform plan: exit status 1", result)
})
t.Run("EmptyErrorPassthrough", func(t *testing.T) {
t.Parallel()
result := templatebuilder.ClassifyProvisionerError("", nil)
require.Equal(t, "", result)
})
t.Run("MultipleDiagnosticBlocks", func(t *testing.T) {
t.Parallel()
result := templatebuilder.ClassifyProvisionerError(
"terraform plan: exit status 1",
[]string{
"Warning: Deprecated resource",
" Use the new resource instead.",
"",
"Error: Invalid reference",
" on main.tf line 12:",
" 12: value = var.undefined",
},
)
require.Contains(t, result, "Deprecated resource")
require.Contains(t, result, "Invalid reference")
require.Contains(t, result, "on main.tf line 12")
})
t.Run("LogContextCappedAtMax", func(t *testing.T) {
t.Parallel()
var logs []string
for i := 0; i < 50; i++ {
logs = append(logs, "Error: problem number "+strings.Repeat("x", 10))
}
result := templatebuilder.ClassifyProvisionerError("exit status 1", logs)
parts := strings.SplitN(result, "\n\n", 2)
require.Len(t, parts, 2, "should have jobError and log context")
contextLines := strings.Split(strings.TrimSpace(parts[1]), "\n")
// 20 diagnostic lines + 1 truncation marker.
require.Equal(t, 21, len(contextLines))
require.Equal(t, "... (truncated)", contextLines[20])
})
t.Run("NonDiagnosticLogsFiltered", func(t *testing.T) {
t.Parallel()
result := templatebuilder.ClassifyProvisionerError(
"terraform plan: exit status 1",
[]string{
"Initializing the backend...",
"Initializing provider plugins...",
"- Finding latest version of hashicorp/aws...",
"- Installing hashicorp/aws v5.0.0...",
},
)
require.Equal(t, "terraform plan: exit status 1", result)
})
}
func TestClassifyProvisionerErrorCategory(t *testing.T) {
t.Parallel()
tests := []struct {
name string
jobError string
logs []string
expected templatebuilder.ProvisionerErrorCategory
}{
{
name: "DNSFailure",
jobError: "init failed",
logs: []string{"dial tcp: lookup registry.terraform.io: no such host"},
expected: templatebuilder.ProvisionerErrorNetwork,
},
{
name: "TLSTimeout",
jobError: "init error",
logs: []string{"net/http: TLS handshake timeout"},
expected: templatebuilder.ProvisionerErrorNetwork,
},
{
name: "AWSNoCredentials",
jobError: "terraform plan: exit status 1",
logs: []string{"Error: No valid credential sources found"},
expected: templatebuilder.ProvisionerErrorAuth,
},
{
name: "CaseInsensitiveAuth",
jobError: "terraform plan: exit status 1",
logs: []string{"Error: ACCESSDENIED on resource"},
expected: templatebuilder.ProvisionerErrorAuth,
},
{
name: "NetworkTakesPrecedenceOverAuth",
jobError: "connection refused",
logs: []string{"AccessDenied: check credentials"},
expected: templatebuilder.ProvisionerErrorNetwork,
},
{
name: "TerraformSyntaxError",
jobError: "terraform plan: exit status 1",
logs: []string{"Error: Unsupported block type"},
expected: templatebuilder.ProvisionerErrorUnknown,
},
{
name: "Empty",
jobError: "",
logs: nil,
expected: templatebuilder.ProvisionerErrorUnknown,
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
require.Equal(t, tc.expected,
templatebuilder.ClassifyProvisionerErrorCategory(tc.jobError, tc.logs))
})
}
}
// The message shown to the user and the category reported as telemetry are
// derived from the same classification, so they must agree.
func TestClassifyProvisionerErrorMessageMatchesCategory(t *testing.T) {
t.Parallel()
tests := []struct {
name string
jobError string
logs []string
category templatebuilder.ProvisionerErrorCategory
messageContains string
}{
{
name: "Network",
jobError: "terraform init: connection refused",
category: templatebuilder.ProvisionerErrorNetwork,
messageContains: "unreachable from your provisioner",
},
{
name: "Auth",
jobError: "AccessDenied: you are not allowed",
category: templatebuilder.ProvisionerErrorAuth,
messageContains: "Cloud provider authentication failed",
},
{
name: "Unknown",
jobError: "terraform plan: exit status 1",
category: templatebuilder.ProvisionerErrorUnknown,
messageContains: "terraform plan: exit status 1",
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
require.Equal(t, tc.category,
templatebuilder.ClassifyProvisionerErrorCategory(tc.jobError, tc.logs))
require.Contains(t,
templatebuilder.ClassifyProvisionerError(tc.jobError, tc.logs),
tc.messageContains)
})
}
}