You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
scripts/validate-catalog.sh says "Runs in CI before deploy". The only workflow that ran it (deploy-pages.yml) was removed in ci: retire GitHub Pages deployment #11. There is no .github/ directory on main; the only check on a PR is Cloudflare Pages, which deploys whatever is pushed and validates nothing. A PR that adds a catalog entry with a wrong source, duplicates a name, or breaks the featured count is deployable today.
A validate workflow on pull_request and push to main that runs bash scripts/validate-catalog.sh with full history checked out (needed for pin verification, see the pins issue). No deploy step; Cloudflare keeps that.
Extend the validator with the checks the repo's own rules already state: pins resolve and hash-match; every modules/, scripts/, skeleton/ file a spec references exists; composes[] names exist in the catalog.
Either add the issue-reference check CONTRIBUTING describes (a small workflow that fails when the PR body has no #N and the author is not a collaborator) or soften the sentence to what is actually enforced.
scripts/validate-catalog.shsays "Runs in CI before deploy". The only workflow that ran it (deploy-pages.yml) was removed in ci: retire GitHub Pages deployment #11. There is no.github/directory onmain; the only check on a PR is Cloudflare Pages, which deploys whatever is pushed and validates nothing. A PR that adds a catalog entry with a wrongsource, duplicates a name, or breaks the featured count is deployable today.CONTRIBUTING.mdsays PRs without a prior issue "are rejected automatically, and the rejection will cite this rule." No automation exists. (For the record, refactor(schema): one canonical container-format companion, not seven copies #18 and authorize-docker-requests: verification pass — the v0.2.1 policy loaded on no installable plugin #19 reference no issue either.)Proposed
validateworkflow onpull_requestandpushtomainthat runsbash scripts/validate-catalog.shwith full history checked out (needed for pin verification, see the pins issue). No deploy step; Cloudflare keeps that.modules/,scripts/,skeleton/file a spec references exists;composes[]names exist in the catalog.#Nand the author is not a collaborator) or soften the sentence to what is actually enforced.